Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

further testing subsystems #11530

Merged
merged 12 commits into from Jul 6, 2022
Merged

further testing subsystems #11530

merged 12 commits into from Jul 6, 2022

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 26, 2022 •
edited

Changelog: Feature: Adding new msys2_ucrt64, msys2_mingw64, msys2_clang64 subsystems in os.subsystem for Windows.
Docs: Omit

Testing:

  • Msys2 subsystems, including ucrt64, clang64, mingw
  • Extending runtime checks
  • Extending subsystem definitions checks
  • Adding Native LLVM/Clang tests

@memsharded memsharded added this to the 1.50 milestone Jun 26, 2022
@memsharded memsharded marked this pull request as ready for review June 27, 2022 16:04
memsharded and others added 2 commits June 29, 2022 09:48
@memsharded @czoido
Update conans/client/conf/__init__.py
d91dce5 
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
@memsharded @czoido
Update conans/client/migrations_settings.py
817e589 
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
@czoido czoido modified the milestones: 1.50, 1.51 Jun 29, 2022
SSE4
SSE4 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good to see these sub-systems are tested and pass tests.
how about recording a runtime used as a sub-setting? or is it supposed to be a follow-up PR?

@memsharded
Copy link
Member Author

how about recording a runtime used as a sub-setting? or is it supposed to be a follow-up PR?

It was removed from this PR, it will be a follow-up PR where those subsettings are actually used.

@memsharded memsharded merged commit 3123a9a into conan-io:develop Jul 6, 2022
@memsharded memsharded deleted the test/subsystems branch July 6, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@lasote lasote lasote approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

@czoido czoido czoido approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.51
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@memsharded @SSE4 @lasote @franramirez688 @czoido